git: various: Fix always-true/false address comparisons (-Waddress).

Matthew Dillon dillon at crater.dragonflybsd.org
Fri May 22 18:43:41 PDT 2026


commit 58a4a85e2942991406bd83e00e9d0df9c84faa93
Author: Abdelkader Boudih <dragonflybsd at seuros.com>
Date:   Thu May 22 07:48:14 2025 +0000

    various: Fix always-true/false address comparisons (-Waddress).
    
    GCC 15 warns when comparing the address of a struct member against
    NULL, since such addresses can never be NULL. Replace with emptiness
    checks where intent was "is it set", remove dead guards otherwise.
    
    Also fixes a latent bug in telnet ring.c where a pointer expression
    was used as a boolean instead of as the RHS of a comparison.

Summary of changes:
 lib/libc/iconv/iconv.c          | 2 +-
 sys/kern/kern_kinfo.c           | 6 ++----
 usr.bin/systat/altqs.c          | 2 +-
 usr.bin/systat/ifstat.c         | 2 +-
 usr.bin/telnet/ring.c           | 2 +-
 usr.sbin/keyserv/crypt_server.c | 2 +-
 usr.sbin/pciconf/pciconf.c      | 4 ++--
 usr.sbin/ppp/ipcp.c             | 4 ++--
 usr.sbin/ppp/server.c           | 2 +-
 usr.sbin/rtadvd/if.c            | 2 +-
 usr.sbin/syslogd/syslogd.c      | 2 +-
 11 files changed, 14 insertions(+), 16 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/58a4a85e2942991406bd83e00e9d0df9c84faa93


-- 
DragonFly BSD source repository


More information about the Commits mailing list