PFS snapshot not going to assigned directory

[Antonio Huete Jiménez]

Hi,

I've been taking a look at the manpage and it does specify the  
snapshots go to the directory specified only upon 'hammer cleanup'.  
But there is no mention to the snapshot dir for normal 'hammer snap'  
calls.
If we force the snapshots' symlinks to always go to the directory  
specified then somebody could complain that they are not created in  
the current directory and instead they go to the snapshots directory.

In any case this is the expected behavior in the current  
implementation but *I* think it would be better if they went to the  
snapshots directory unless another directory is specified, but for  
this we'd have to add the code to handle it.

Cheers,
Antonio Huete


Quoting Antonio Huete Jiménez <tuxillo at quantumachine.net>:

> Hi Rohit,
>
> I'll have a look at this later today.
>
> Cheers,
> Antonio Huete
>
> Quoting Rohit Menon <rohit.forum33 at gmail.com>:
>
>> Hi,
>>
>> I have currently configured a PFS with status as given below.
>>
>> /Backup3/vms-lxc    PFS #1 {
>>    sync-beg-tid=0x0000000000000001
>>    sync-end-tid=0x0000000121e5d400
>>    shared-uuid=3df3d26e-8552-11e4-8192-4587fc6b58f4
>>    unique-uuid=3df3d298-8552-11e4-8192-4587fc6b58f4
>>    label=""
>>    *snapshots="/Backup4/pfs-snapshots/vms-lxc"*
>>    prune-min=00:00:00
>>    operating as a MASTER
>> }
>>
>> As can be seen the the snapshot directory is configured to another disk.
>> However the snapshots are being taken in the pfs itself.
>>
>> dfly-bkpsrv2# pwd
>> /Backup3/pfs/@@-1:00001
>>
>> ls
>>
>>
>> lrwxr-xr-x  1 root  wheel  37 Dec 18 14:30 snap-20141218-1430 ->
>> /Backup3/vms-lxc/@@0x0000000119445e90
>> lrwxr-xr-x  1 root  wheel  37 Dec 19 14:30 snap-20141219-1430 ->
>> /Backup3/vms-lxc/@@0x0000000000000000
>> drwxr-xr-x  1 root  wheel   0 Dec 17 01:13 vms1
>> drwxr-xr-x  1 root  wheel   0 Dec 17 01:13 vms2
>> drwxr-xr-x  1 root  wheel   0 Dec 17 01:13 vms3
>> drwxr-xr-x  1 root  wheel   0 Dec 18 16:59 vms4
>> drwxr-xr-x  1 root  wheel   0 Dec 17 01:13 vms5
>> drwxr-xr-x  1 root  wheel   0 Dec 17 01:13 vms6
>> drwxr-xr-x  1 root  wheel   0 Dec 17 01:13 vms7
>> drwxr-xr-x  1 root  wheel   0 Dec 17 01:13 vms8
>>
>>
>> As a side note the snapshots are taken via *crontab *instead of using the
>> default settings.
>>
>>
>> 30 14 * * * hammer snap /Backup3/vms-lxc "rsync"
>>
>>
>>
>> I can see that there is hammer snapshot where I can specify the behaviour,
>> however shouldn't the above command take a backup to
>>
>>
>> */Backup4/pfs-snapshots/vms-lxc*