No subject

[Unknown]

<20070119024021.GH19888 at les.ath.cx>
From: "Simon 'corecode' Schubert" <corecode at fs.ei.tum.de>
Subject: Re: cvs commit: src/sys/boot/pc32/libi386 biosacpi.c src/sys/conf
         acpi.mk files src/sys/dev/acpica5 Makefile Makefile.inc         acdragonfly.h
 acpi.c acpi_acad.c acpi_button.c acpi_cmbat.c         acpi_cpu.c acpi_ec.c
 acpi_lid.c acpi_resource.c acpi_thermal.c ...
Date: Fri, 19 Jan 2007 13:45:26 +0100
BestServHost: crater.dragonflybsd.org
List-Post: <mailto:commits at crater.dragonflybsd.org>
List-Subscribe: <mailto:commits-request at crater.dragonflybsd.org?body=subscribe>
List-Unsubscribe: <mailto:commits-request at crater.dragonflybsd.org?body=unsubscribe>
List-Help: <mailto:commits-request at crater.dragonflybsd.org?body=help>
List-Owner: <mailto:owner-commits at crater.dragonflybsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig5F67AD5F4DFFB99876D5FB8C"
In-Reply-To: <20070119024021.GH19888 at les.ath.cx>
Sender: commits-errors at crater.dragonflybsd.org
Errors-To: commits-errors at crater.dragonflybsd.org
Lines: 67
NNTP-Posting-Host: 216.240.41.25
X-Trace: 1169210910 crater_reader.dragonflybsd.org 830 216.240.41.25
Xref: crater_reader.dragonflybsd.org dragonfly.commits:14014

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig5F67AD5F4DFFB99876D5FB8C
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

YONETANI Tomokazu wrote:
>> Uff, now I've got it.
>> It hangs in OsdCache.c:AcpiOsAcquireObject
>>
>> Object =3D objcache_get(Cache->cache, M_WAITOK);

Heh.  The ACPI docs are simply not nice enough:

/************************************************************************=
*******
 *
 * FUNCTION:    AcpiOsCreateCache
 *
 * PARAMETERS:  CacheName       - Ascii name for the cache
 *              ObjectSize      - Size of each cached object
 *              MaxDepth        - Maximum depth of the cache (in objects)=

 *              ReturnCache     - Where the new cache object is returned

we interpret MaxDepth as "object limit".

but look what utcache.c/AcpiOsReleaseObject does:

    /* If cache is full, just free this object */

    if (Cache->CurrentDepth >=3D Cache->MaxDepth)
    {
        ACPI_FREE (Object);
        ACPI_MEM_TRACKING (Cache->TotalFreed++);
    }

    /* Otherwise put this object back into the cache */

Quite differently.  Basically MaxDepth is "maximum number of unallocated =
objects", not "maximum number of allocated objects".  bummer :)

cheers
  simon

--=20
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low =E2=82=AC=E2=82=AC=E2=82=AC NOW!1  +++=
      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \


--------------enig5F67AD5F4DFFB99876D5FB8C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (DragonFly)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFsL1pr5S+dk6z85oRAnzUAJ40OVbXA1eZM7ygyGTcs+ChJXh8GACfQC/K
yuZzOh2kHYMls+uvY4Zf/nc=
=eXeu
-----END PGP SIGNATURE-----

--------------enig5F67AD5F4DFFB99876D5FB8C--