[DragonFlyBSD - Bug #3059] sbin/camcontrol/camcontrol.c: pointless code ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3059 has been updated by lubos.


As discussed on IRC with swildner, I've sent an email to ngie (freebsd.org) and asked him about reasoning behind fixing this warning in FreeBSD simply by removing the condition which follows my proposed change. This "problem" appears to be present since the beginning of FreeBSD SVN repository so I couldn't find any more info on why return value from scsiserial is not taken into account.

-- 

Lubos Boucek

----------------------------------------
Bug #3059: sbin/camcontrol/camcontrol.c: pointless code ?
http://bugs.dragonflybsd.org/issues/3059#change-13233

* Author: dcb
* Status: New
* Priority: Low
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
dragonfly/sbin/camcontrol/camcontrol.c:688] -> [dragonfly/sbin/camcontrol/camcontrol.c:694]: (warning) Identical condition 'error!=0', second condition is always false

Source code is

    if (error != 0)
        return(error);

    if (arglist & CAM_ARG_GET_SERIAL)
        scsiserial(device, retry_count, timeout);

    if (error != 0)
        return(error);




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account