[DragonFlyBSD - Bug #3059] sbin/camcontrol/camcontrol.c: pointless code ?

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3059 has been updated by lubos.


Perhaps assignment to `error' is missing? Like this:

diff --git a/sbin/camcontrol/camcontrol.c b/sbin/camcontrol/camcontrol.c
index 0fef6e5..1b98c47 100644
--- a/sbin/camcontrol/camcontrol.c
+++ b/sbin/camcontrol/camcontrol.c
@@ -689,7 +689,7 @@ scsidoinquiry(struct cam_device *device, int argc, char **argv,
                return(error);
 
        if (arglist & CAM_ARG_GET_SERIAL)
-               scsiserial(device, retry_count, timeout);
+               error = scsiserial(device, retry_count, timeout);
 
        if (error != 0)
                return(error);

----------------------------------------
Bug #3059: sbin/camcontrol/camcontrol.c: pointless code ?
http://bugs.dragonflybsd.org/issues/3059#change-13209

* Author: dcb
* Status: New
* Priority: Low
* Assignee: 
* Category: 
* Target version: 
----------------------------------------
dragonfly/sbin/camcontrol/camcontrol.c:688] -> [dragonfly/sbin/camcontrol/camcontrol.c:694]: (warning) Identical condition 'error!=0', second condition is always false

Source code is

    if (error != 0)
        return(error);

    if (arglist & CAM_ARG_GET_SERIAL)
        scsiserial(device, retry_count, timeout);

    if (error != 0)
        return(error);




-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account