unreadable pflog file: solved: patch

[karu.pruun]

On Mon, Apr 28, 2014 at 7:13 PM, Francois Tigeot wrote:
>
> On Mon, Apr 21, 2014 at 02:57:35PM +0900, karu.pruun wrote:
> >
> > Recently I complained that the /var/log/pflog file in DFly 3.6 is
> > unreadable by tcpdump. I might have found the cause; apologies: I'm not a
> > developer and not even versed in C so more knowledgeable people might be
> > able to comment and improve on this. Anyhow, I compared the code of pflogd
> > of OpenBSD, FreeBSD and DragonFly, and tracked the issue to how DragonFly
> > writes to the pflog logfile. The patch for DragonFly_RELEASE_3_6 is
> > included and seems to work so far: tcpdump is now able to output from
> > /var/log/pflog.
>
> Thanks for the patch, I have pushed a slightly modified version:
> - some whitespace fixes
> - #ifdef __DragonFly__ lines removed, our pf version is out of date and nobody
>   is going to run it on OpenBSD or any other operating system.
> - a more explicit commit message

Glad it helped. I just noticed something that might be needed from
FreeBSD pflogd to ensure consistency of the logfile. Should I send the
patch to submit at lists.dragonflybsd.org or the bugtracking system?

Peeter

--