est module

[Thomas Schlesinger]

Am Donnerstag, 22. Juni 2006 15:36 schrieb joerg at xxxxxxxxxxxxxxxxx:
> On Thu, Jun 22, 2006 at 02:42:58PM +0200, Thomas Schlesinger wrote:
> > Unfortunately, it seems not to support my Pentium-M 1.73GHz (Pentium
> > M-740, 533MHz FSB):
>
> NetBSD has
> /* Intel Pentium M processor 740 1.73 GHz */
> static const struct fq_info pentium_m_n740[] = {
>        { 1733, 1356 },
>        { 1333, 1212 },
>        { 1067, 1100 },
>        {  800,  988 },
> };
>
> static const struct fqlist pentium_m_dothan[] = {
> 	...
>         ENTRY("1.73", 0x06d8, pentium_m_n740, 4),
> 	...
> };
>
> Try to adopt it.
>
> Joerg

Unfortunately, I've failed to adopt it. 

That's, what I did:

I've added the above parameter block 

[..]
/*
 * Data from
 * Intel Pentium M Processor Datasheet (Order Number 252612), Table 5
 */

/* Intel Pentium M processor 740 1.73 GHz */
static freq_info pentium_m_n740[] = {
       { 1733, 1356 },
       { 1333, 1212 },
       { 1067, 1100 },
       {  800,  988 },
};
[..]

from line 71ff.

Then, I added an entry in line 394ff:

[..]
static cpu_info ESTprocs[] = {
	CPUINFO(pentium_m_n740, 1733, 1356, 800, 988),
[..]

That wasn't enough. I've found a check on the processor name, beginning 
with "Intel(R) Pentium(R) M processor", in line 538ff. My processor was named 
with "Intel(R) Pentium(R) M processor 1.73GHz", so I've commented out this 
check:

/*		if (strncmp(hwmodel, "Intel(R) Pentium(R) M processor", 31) ||

		    (findcpu() != 0)) {
			printf("%s: Enhanced Speedstep not supported"
			       " on this processor\n", hwmodel);
			break;
		}
*/

When I load the est-module with this disabled check, my notebook reboots.

What would be the right way to adopt it?

Thanks,
Thomas