em driver issues

Matthew Dillon dillon at apollo.backplane.com
Thu Feb 3 17:16:26 PST 2005


::EM
:
:>    This sounds like a network stack/mbuf issue.  Could you please post 
:>    the backtrace of the panic ? 
:
:Ok, here is the summary of the backtrace:
:
:panic: Trying to free NULL pointer
:panic()
:free()
:m_clalloc()

    Well, that was an easy fix.  I've committed a fix, please continue
    to try to crash the box with packets!

    The patch is enclosed.

					-Matt
					Matthew Dillon 
					<dillon at xxxxxxxxxxxxx>

Index: uipc_mbuf.c
===================================================================
RCS file: /cvs/src/sys/kern/uipc_mbuf.c,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- uipc_mbuf.c	18 Nov 2004 01:42:26 -0000	1.29
+++ uipc_mbuf.c	4 Feb 2005 01:14:27 -0000	1.30
@@ -82,7 +82,7 @@
  *
  * @(#)uipc_mbuf.c	8.2 (Berkeley) 1/4/94
  * $FreeBSD: src/sys/kern/uipc_mbuf.c,v 1.51.2.24 2003/04/15 06:59:29 silby Exp $
- * $DragonFly: src/sys/kern/uipc_mbuf.c,v 1.29 2004/11/18 01:42:26 dillon Exp $
+ * $DragonFly: src/sys/kern/uipc_mbuf.c,v 1.30 2005/02/04 01:14:27 dillon Exp $
  */
 
 #include "opt_param.h"
@@ -428,6 +428,8 @@
 			mbstat.m_wait++;
 			mcl = malloc(sizeof(*mcl), 
 					M_MBUFCL, M_WAITOK|M_NULLOK|M_ZERO);
+			if (mcl == NULL)
+				break;
 		}
 
 		/*





More information about the Users mailing list