[DragonFlyBSD - Submit #1700] skip boot2 menu on <enter>

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #1700 has been updated by tuxillo.


I've created a VM with a UFS installation and no dedicated /boot partition:

<pre>
root@:~ # df -h /boot 
Filesystem     Size   Used  Avail Capacity  Mounted on
/dev/vbd0s1d  32.5G  1575M  28.3G     5q    /
</pre>

I'm unable to reproduce this issue. Could it be that it happens only in some hardware because pressing the Enter key produces a different character?


----------------------------------------
Submit #1700: skip boot2 menu on <enter>
http://bugs.dragonflybsd.org/issues/1700#change-14261

* Author: Johannes.Hofmann
* Status: In Progress
* Priority: Normal
* Assignee: tuxillo
* Target version: 6.4
----------------------------------------
Hi,

tuxillo noticed that the trick to speedup booting by hitting <enter>
does not work with default UFS-based installations, as those have no
separate /boot partition, and therefore the default location for the
loader is wrong (it had been changed to match default HAMMER
installations in commit:3735e368a1bdbe773c79c34512f49c905ff77bd7)

We could change boot2 to just continue it's normal operation without
entering the prompt when the user hits <enter>. That way one can avoid
the delay on UFS and HAMMER systems:

<pre>
<code class="ruby">
diff --git a/sys/boot/pc32/boot2/boot2.c b/sys/boot/pc32/boot2/boot2.c
index 459436f..55516be 100644
--- a/sys/boot/pc32/boot2/boot2.c
+++ b/sys/boot/pc32/boot2/boot2.c
@@ -346,7 +346,7 @@ main(void)
      */
     if (autoboot && !*kname) {
 	memcpy(kname, PATH_BOOT3, sizeof(PATH_BOOT3));
-	if (!keyhit(3*SECOND)) {
+	if (!keyhit(3*SECOND) || xgetc(0) == '\r') {
 	    load();
 	    memcpy(kname, PATH_BOOT3_ALT, sizeof(PATH_BOOT3_ALT));
 	    load();

</code>
</pre>

To actually enter the prompt one has to hit any other key (e.g. Esc).

The check for '\r' works ok for me, but maybe we also need to check
for '\n'?

Cheers,
Johannes



-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account