[DragonFlyBSD - Submit #3254] [PATCH] Add initial multi-volumes support for HAMMER2

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3254 has been updated by dillon.

Assignee set to dillon

This looks very nice!  And it also looks like you are validating the volume set by checking that the fsid uuid matches.  I did a quick review and came up with the following:

* In hammer2_get_volume() you return a non-NULL vol in the case of failure, because 'vol' is assigned inside the loop.  This definitely needs to be fixed to avoid corrupting the filesystem when the volume set is incomplete.

-Matt

----------------------------------------
Submit #3254: [PATCH] Add initial multi-volumes support for HAMMER2
http://bugs.dragonflybsd.org/issues/3254#change-13933

* Author: tkusumi
* Status: New
* Priority: Normal
* Assignee: dillon
* Category: 
* Target version: 
----------------------------------------
This commit adds initial multi-volumes support for HAMMER2. Maximum
supported volumes is 64. The feature and implementation is similar to
multi-volumes support in HAMMER1.

See commit message in below for details.
https://leaf.dragonflybsd.org/~tkusumi/diff/0001-sys-vfs-hammer2-Add-initial-multi-volumes-support-fo.patch

The patch applies on top of below commit or after.
064b66eab3015e74bb4b2ab05de363471dd314e6 ("usr.sbin/fstyp: Minor HAMMER2 fixes")

If no comments, I'll commit this in another week or so.



-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account