[DragonFlyBSD - Submit #3126] Bring in BIOC{S,G}FEEDBACK

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #3126 has been updated by sepherosa.


Patch looks good.  Commit it!

On Wed, Apr 18, 2018 at 4:45 PM, Sepherosa Ziehau <sepherosa at gmail.com> wrote:
> network stack :)
>
> On Wed, Apr 18, 2018 at 4:40 PM,
> <bugtracker-admin at leaf.dragonflybsd.org> wrote:
>> Issue #3126 has been updated by tuxillo.
>>
>> File bpf_biocfeedback.patch added
>>
>> Attached the patch with the corrections. By the way, who frees the mc mbuf which is passed to ifp->if_input ?
>>
>> ----------------------------------------
>> Submit #3126: Bring in BIOC{S,G}FEEDBACK
>> http://bugs.dragonflybsd.org/issues/3126#change-13413
>>
>> * Author: tuxillo
>> * Status: In Progress
>> * Priority: Normal
>> * Assignee: tuxillo
>> * Category: net
>> * Target version:
>> ----------------------------------------
>> Hi,
>>
>> The port net/vde2 uses a ioctl command BIOCFEEDBACK for FreeBSD to allow host-guest communication in a vde switch. The attached patch is the initial attempt to bring that ioctl command from NetBSD.
>> It compiles but it's untested until I figure out how to test it.
>>
>> I'd need some pointers though:
>>
>> - Is it okay to use directly ifp->if_input directly? Isn't there a mechanism similar to the one used in bpfwrite() -> bpf_output_dispatch but for input?
>> - If it's okay to use ifp->if_input directly, wouldn't it need some locking?
>>
>> Cheers,
>> Antonio Huete
>>
>> ---Files--------------------------------
>> bpf_biocfeedback.patch (3.37 KB)
>>
>>
>> --
>> You have received this notification because you have either subscribed to it, or are involved in it.
>> To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account
>
>
>
> --
> Tomorrow Will Never Die



-- 
Tomorrow Will Never Die

----------------------------------------
Submit #3126: Bring in BIOC{S,G}FEEDBACK 
http://bugs.dragonflybsd.org/issues/3126#change-13415

* Author: tuxillo
* Status: In Progress
* Priority: Normal
* Assignee: tuxillo
* Category: net
* Target version: 
----------------------------------------
Hi,

The port net/vde2 uses a ioctl command BIOCFEEDBACK for FreeBSD to allow host-guest communication in a vde switch. The attached patch is the initial attempt to bring that ioctl command from NetBSD.
It compiles but it's untested until I figure out how to test it.

I'd need some pointers though:

- Is it okay to use directly ifp->if_input directly? Isn't there a mechanism similar to the one used in bpfwrite() -> bpf_output_dispatch but for input?
- If it's okay to use ifp->if_input directly, wouldn't it need some locking?

Cheers,
Antonio Huete

---Files--------------------------------
bpf_biocfeedback.patch (3.37 KB)


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account