[DragonFlyBSD - Submit #2717] Out of range numeric handling

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #2717 has been updated by tuxillo.

Assignee set to tuxillo
% Done changed from 100 to 0

Hi,

The patch looks okay besides a few wrong tabs which is really minor.
But I'd like to understand why you don't use strtonum() more consistently, for example you use strtol() and an ERANGE check in some other places:

-                               dtrwait = atoi(argv[3]);
+                               dtrwait = strtol(argv[3], NULL, 10);
+                               if (errno == ERANGE)
+                                       usage();

Cheers,
Antonio Huete

----------------------------------------
Submit #2717: Out of range numeric handling
http://bugs.dragonflybsd.org/issues/2717#change-12562

* Author: dclink
* Status: Feedback
* Priority: Normal
* Assignee: tuxillo
* Category: Userland
* Target version: 4.2.x
----------------------------------------
In a similar way than OpenBSD, the numeric values overflows are checked.

---Files--------------------------------
patch-atoi.txt (16.4 KB)


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account