[DragonFlyBSD - Submit #1398] (In Progress) hdestroy(3) restricts hash key to point to malloc'ed space

[bugtracker-admin at leaf.dragonflybsd.org]

Issue #1398 has been updated by tuxillo.

Tracker changed from Bug to Submit
Description updated
Category set to Userland
Status changed from New to In Progress
Target version set to 4.2.x

Moving to submit.
Still relevant.

----------------------------------------
Submit #1398: hdestroy(3) restricts hash key to point to malloc'ed space
http://bugs.dragonflybsd.org/issues/1398#change-12463

* Author: Anonymous
* Status: In Progress
* Priority: Normal
* Assignee: 
* Category: Userland
* Target version: 4.2.x
----------------------------------------
Salute.

hdestroy(3) frees the memory pointed to by the hash key. In other words it
expects the user to always have malloc()'ed rather than used static allocation
for the hash key. This doesn't apply to the data associated with the key.

Although POSIX standard doesn't say much on this particular topic:

1) This is unnecessarily restrictive. If the user wants static allocation, we
should allow this. If she wants dynamic then let *her* free the memory she
malloc()'ed.

2) It is in conflict with the example code in the POSIX page. The code 
segfaults if you add an hdestroy() call in the end of it.

3) Programs that target other implementations may segfault in DragonFly (that's
how I discovered it). AFAIK sunOS 5.10 and a recent glibc work fine, whereas
{Net, Free, DragonFly}BSD all are affected because they share the same code.
(One could argue that all programs written with the *BSD version in mind would
result in a memory leak. But still I think these programs (if any) should be fixed.)

Any thoughts ?

Cheers,
Stathis

---Files--------------------------------
hdestroy-3-Don-t-call-free-3-for-each-hash-key.patch (2.27 KB)


-- 
You have received this notification because you have either subscribed to it, or are involved in it.
To change your notification preferences, please click here: http://bugs.dragonflybsd.org/my/account