On 07/10/2010 08:58, Alex Hornung wrote: Patch looks good to me, but you could move the destroy_dev() out of under the tty_token; the tty_token in drivers is mainly intended to serialize the tty structure access and such. Disregard my comment... I read 'reltoken' instead of 'gettoken'. It is already outside the token-protected section.