MPLS support for DragonFly
Sepherosa Ziehau
sepherosa at gmail.com
Wed Jul 2 00:41:49 PDT 2008
On 7/2/08, Nuno Antunes <nuno.antunes at gmail.com> wrote:
> On Wed, Jul 2, 2008 at 4:00 AM, Sepherosa Ziehau <sepherosa at gmail.com> wrote:
> > On 7/2/08, Nuno Antunes <nuno.antunes at gmail.com> wrote:
> >> Hi All,
> >>
> >> I have this patch [1] sitting in my tree for several months now (just
> >> caught up with HEAD last weekend) but maybe it's time to ask others
> >> opinion before it grows spider webs on it :). It adds MPLS (Multi
> >> Protocol Label Switching) support to DragonFly and still has some
> >> loose ends but basically it works. For now, only static mpls routes
> >> are supported. To make it really usable, an LDP and / or RSVP
> >> implementation would be needed to accompany it. If reviews are
> >> positive I would like to put it in and commit it maybe after the
> >> release in order to allow for wider testing.
> >>
> >> [1] http://leaf.dragonflybsd.org/~nant/wip/mpls-20080701.patch
> >
> > The patch looks good. Just nit picking: would you please adjust the
> > style in mpls_demux.c? Things like
> >
> > struct lwkt_port *
> > mpls_mport(struct mbuf **mp) {
> > }
> >
> > to
> >
> > struct lwkt_port *
> > mpls_mport(struct mbuf **mp)
> > {
> > }
> >
> >
> > If you are going to commit it, I will commit a fix on ETHER_INPUT2
> > path, once you have done.
> >
> > Best Regards,
> > sephe
> >
> > --
> > Live Free or Die
> >
>
>
> Sure, thanks! :)
>
> Ok should i put it in before or after release?
I am ok to have it before release; don't know other folks opinion tho.
Best Regards,
sephe
--
Live Free or Die
More information about the Submit
mailing list