Journaling patches
Steve O'Hara-Smith
steve at sohara.org
Fri Jan 26 02:41:58 PST 2007
On Thu, 25 Jan 2007 10:18:04 -0800 (PST)
Matthew Dillon <dillon at apollo.backplane.com> wrote:
> : Hi,
> :
> : The first attached patch (jscan_patches) makes the -D option of
> :jscan work. It includes tests that the directory actually exists. Apply
> :within /usr/src/sbin/jscan
>
> Ok, this one needs a little work. You are calling chdir() on every
> single journaling record rather then just once at the beginning
> (e.g. up in jscan.c before the loops that call dump_mirror()).
>
> The bit in jscan.c should use !S_ISDIR(sb.st_mode) instead of
> (sb.st_mode & S_IFDIR).
The attached patch (to jscan.c only) addresses these points and
works nicely in my vkernel environment.
> : Having the journal appears to reduce the filesystem performance
> to :about one third of it's unjournaled level however some of that is
> probably :due to the journal being on the same disc as the filesystem.
>
> Write performance will suffer a lot with this sort of journaling,
> though it is buffered fairly well within the kernel.
Indeed, I wasn't complaining just leaving some figures so that
perhaps others would not be surprised.
--
C:>WIN | Directable Mirror Arrays
The computer obeys and wins. | A better way to focus the sun
You lose and Bill collects. | licences available see
| http://www.sohara.org/
Attachment:
jscan.patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bin00007.bin
Type: application/octet-stream
Size: 1223 bytes
Desc: "Description: Binary data"
URL: <http://lists.dragonflybsd.org/pipermail/submit/attachments/20070126/e5e96b1b/attachment-0019.bin>
More information about the Submit
mailing list