kern_ktr.c warning patch

Simon 'corecode' Schubert corecode at fs.ei.tum.de
Wed Jan 18 12:27:30 PST 2006


On 18.01.2006, at 17:09, Alexey Slynko wrote:

Hi,
convert unneccessary vprintf to printf
Index: /usr/src1/sys/kern/kern_ktr.c
===================================================================
RCS file: /mnt/share/dragonfly-cvs/src/sys/kern/kern_ktr.c,v
retrieving revision 1.12
diff -u -r1.12 kern_ktr.c
--- /usr/src1/sys/kern/kern_ktr.c	12 Dec 2005 08:15:02 -0000	1.12
+++ /usr/src1/sys/kern/kern_ktr.c	18 Jan 2006 14:25:20 -0000
@@ -438,6 +438,7 @@
 	struct ktr_entry *entry;
 	int cpu;
+	entry = NULL;
 	cpu = mycpu->gd_cpuid;
 	if (ktr_buf[cpu]) {
 		crit_enter();
@@ -471,7 +472,7 @@
 		if (ktr_verbose > 1) {
 			printf("%s.%d\t", entry->ktr_file, entry->ktr_line);
 		}
-		vprintf(info->kf_format, ptr);
+		printf(info->kf_format, ptr);
did you actually try this?

cheers
  simon
--
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \
Attachment:
PGP.sig
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pgp00000.pgp
Type: application/octet-stream
Size: 186 bytes
Desc: "Description: This is a digitally signed message part"
URL: <http://lists.dragonflybsd.org/pipermail/submit/attachments/20060118/3c6aaa0a/attachment-0019.obj>


More information about the Submit mailing list