basename bug [patch attached]

Jeroen Ruigrok/asmodai asmodai at
Fri Sep 23 00:08:23 PDT 2005

-On [20050922 23:04], Kyle Butt (kylebutt at xxxxxxxxx) wrote:
>I found a bug in basename (discovered via pkgsrc) and I've
>attached a patch to fix it. Hopefully this helps.

>-	suffix = 0;
>-	suffixlen = NULL;
>+	suffix = NULL;
>+	suffixlen = 0;

DUH, I fixed this.  For some reason I had it reversed in the code.

>+	if (argc == 2) {
>+		suffix = argv[1];
>+		suffixlen = strlen(argv[1]);
>+	}

This is already present in the latest CVS sources, so I wonder where it
comes from in yours.

Thing is, FreeBSD added extra flags to basename to cut of a bunch of files
with a suffix and I am not 100% sure we want that functionality or not.

SO, with the latest files from CVS, can you check again?

Jeroen Ruigrok van der Werven <asmodai(at)> / asmodai / kita no mono
Free Tibet! |   |
Experience keeps a dear school, yet Fools will learn in no other.

More information about the Submit mailing list