sysctl warns6 cleanup
Chris Pressey
cpressey at catseye.mine.nu
Sat Jan 8 11:21:15 PST 2005
On Sat, 8 Jan 2005 20:02:30 +0100
Joerg Sonnenberger <joerg at xxxxxxxxxxxxxxxxx> wrote:
> On Sat, Jan 08, 2005 at 05:17:17PM +0100, Peter Schuller wrote:
> > @@ -518,20 +519,20 @@
> > case 'A':
> > if (!nflag)
> > printf("%s%s", name, sep);
> > - printf("%.*s", len, p);
> > + printf("%.*s", (int)len, p);
> > return (0);
> >
>
> There should be at least a check for the value of len, to ensure that
> it actually fits into an int.
Heh... come to think of it, isn't this kind of a silly use of printf()?
Couldn't we just use fwrite(p, len, 1, stdout) here instead?
-Chris
More information about the Submit
mailing list