Matthew Dillon dillon at
Thu Feb 10 10:19:22 PST 2005

:Hi all,
:the two patches
:(kernel part) and
:(pfctl support) add the infrastructure for ALTQ.
:Currently supported are tun(4), sppp(4), ppp(4) and wi(4). I'll
:add support for more drivers later.
:If noone objects, this goes into the tree tomorrow.

    It looks ok except for the various IFQ_*() macros.  Passing a variable
    name as an argument to a macro (e.g. err) which then assigns the 
    variable creates a lot of confusion.  The NFSM code did this (albeit 
    much more aggregiously) and it created a real mess.

    Could you make those IFQ_*() macros real procedures instead of macros?
    Or at least real inline procedures.

					Matthew Dillon 
					<dillon at xxxxxxxxxxxxx>

More information about the Submit mailing list