[PATCH] libexec/fingerd WARNS=6 cleanup

Liam J. Foy liamfoy at sepulcrum.org
Sat Apr 30 04:52:07 PDT 2005


Hello Joe!

> +			if (secure && ap == &av[3])
> +				err(1, "must provide username");
>  			break;

err() will print the error message with errno. Of course, errno
is not set here. This will lead to an invalid err message. You
really want to use errx() which will not use errno.

> +		if (secure && strchr(*ap, '@')) 
> +			err(1, "forwarding service denied");
>  

Cheers,
-- 
Liam J. Foy
liamfoy at xxxxxxxxxxxxx
http://www.bsd-systems.co.uk





More information about the Submit mailing list