timed contains buffer overflows, and more

Douwe Kiela virtus at wanadoo.nl
Fri Sep 3 11:49:01 PDT 2004


"Matthew Dillon" <dillon at xxxxxxxxxxxxxxxxxxxx> wrote:
>     So, for example, I think it would be ok to mix (void) removal with,
>     say, declaration/assignment separation, but it would not be ok to mix
>     either of those with functional changes like strcpy->strlcpy.  You
could
>     mix strcpy->strlcpy and sprintf->snprintf changes together into one
>     patch but you should not mix that with, unrelated cleanups.
>
>     As it is I am going to have to separate out the timed work into two
>     separate commits.  I would prefer not to have to do that again because
>     it is going to take two hours of my time to fix just timed and it
doesn't
>     really help the project out if the patches you submit require a
committer
>     to spend as long or longer reviewing and/or separating them.
Alright.. I will do this.. and submit the patches to bugzilla. :-)






More information about the Submit mailing list