style(9) sweep on config(8)

Chris Pressey cpressey at catseye.mine.nu
Thu Mar 4 12:15:00 PST 2004


Hi again.

I want to do some work on /usr/sbin/config, and I thought it would be a
good idea to do a style(9) sweep on it first (otherwise I'll be tempted
to make style changes while hacking it...)

I split my changes into three cumulative patches to make them easier to
review, but they can be combined and committed all at once if repochurn
is an issue.

config0.diff:
	- change K&R declarations to ANSI declarations
	- remove ``register'' keywords

config1.diff:
	- no space after casts
	- no space, but yes parens, after sizeof and return
	- spaces around binary operators
	- other minor whitespace issues

config2.diff
	- use NULL instead of 0 for pointers
	- explicitly compare to 0 or NULL for non-booleans

-Chris
Attachment:
config0.diff.gz
Description: Binary data
Attachment:
config1.diff.gz
Description: Binary data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bin00002.bin
Type: application/octet-stream
Size: 4631 bytes
Desc: "Description: Binary data"
URL: <http://lists.dragonflybsd.org/pipermail/submit/attachments/20040304/1ba451b1/attachment-0054.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bin00001.bin
Type: application/octet-stream
Size: 5267 bytes
Desc: "config2.diff.gz"
URL: <http://lists.dragonflybsd.org/pipermail/submit/attachments/20040304/1ba451b1/attachment-0055.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bin00000.bin
Type: application/octet-stream
Size: 2172 bytes
Desc: "Attachment:"
URL: <http://lists.dragonflybsd.org/pipermail/submit/attachments/20040304/1ba451b1/attachment-0056.bin>


More information about the Submit mailing list