style(9) sweep on config(8)

Eirik Nygaard eirikn at kerneled.com
Thu Mar 4 12:53:56 PST 2004


On Thu, Mar 04, 2004 at 12:19:38PM -0800, Chris Pressey wrote:
> Hi again.
> 
> I want to do some work on /usr/sbin/config, and I thought it would be a
> good idea to do a style(9) sweep on it first (otherwise I'll be tempted
> to make style changes while hacking it...)
> 
> I split my changes into three cumulative patches to make them easier to
> review, but they can be combined and committed all at once if repochurn
> is an issue.
> 
> config0.diff:
> 	- change K&R declarations to ANSI declarations
> 	- remove ``register'' keywords
> 
> config1.diff:
> 	- no space after casts
> 	- no space, but yes parens, after sizeof and return
> 	- spaces around binary operators
> 	- other minor whitespace issues
> 
> config2.diff
> 	- use NULL instead of 0 for pointers
> 	- explicitly compare to 0 or NULL for non-booleans
> 

The patches are commited, thanks.

-- 
Eirik Nygaard
eirikn at xxxxxxxxxxxx    Never let a computer know you're in a hurry.
Attachment:
pgp00002.pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pgp00002.pgp
Type: application/octet-stream
Size: 187 bytes
Desc: "Description: PGP signature"
URL: <http://lists.dragonflybsd.org/pipermail/submit/attachments/20040304/162a40c1/attachment-0017.obj>


More information about the Submit mailing list