bin/sh/mksyntax.c has wrong error handling [patch]

Jeroen Ruigrok/asmodai asmodai at
Fri Jul 23 00:01:30 PDT 2004

-On [20040722 21:52], Douwe Kiela (virtus at xxxxxxxxxx) wrote:
>bin/sh/mksyntax.c contains call to the perror() function, while
>sh has its own error function, that is used everywhere in the code,
>and is define in error.c, namely error(). For code consistency mksyntax.c
>should also be made to use this function, here is a patch:

Not applied.

mksyntax.c is a build time tool used to generate syntax.[ch].
In effect, error() from error.c is a wrapper function which calls
exverror(), which is a specialised error function that also does interrupt
clearing, tracing, flushing, and exception handling.

Thus for mksyntax.c perror() is absolutely valid and no change is needed.

Jeroen Ruigrok van der Werven <asmodai(at)> / asmodai / kita no mono
Free Tibet! |   |
See with your eyes, hear with your ears.  Nothing is hidden.

More information about the Submit mailing list