minor emu10k1.c cleanup
joerg at britannica.bec.de
Wed Feb 25 08:37:07 PST 2004
On Sun, Feb 22, 2004 at 07:31:43PM -0800, Chris Pressey wrote:
> Basically I got annoyed at the "trigraphs encountered" warning I was
> getting during buildkernel, so I found and eliminated them. Turns out
> they were caused by the sequence "??)" embedded in a comment. It might
> be more elegant to change the compiler to ignore (apparent) trigraphs in
> comments, but also a lot more work, so I just added some spaces so they
> don't trigger the warning.
Well, I have replaced some already with (?).
> While here I made some small style-related changes (test for a null
> pointer should be explicit...)
I changed that by adding a default case of return ENXIO.
> I'll try to figure out what's up with the code I marked XXX, by looking
> through CVS logs, but I don't have one of these soundcards to test it
> with so I'm not too hopeful.
Send me the answer of the FreeBSD maintainer.
More information about the Submit