/usr/bin/dirname calls getopt but doesn't need it [patch]

Joerg Sonnenberger joerg at britannica.bec.de
Sun Aug 15 09:10:14 PDT 2004


On Thu, Jul 22, 2004 at 07:44:50PM +0200, Douwe Kiela wrote:
> Hello,
> 
> /usr/bin/dirname uses getopt(), but doesn't do anything with it, thus it can
> be removed.
> A patch is to be found here:
> 
> http://virtus.ath.cx/dfbsd/dirname.c.diff

The patch doesn't work. The getopt is useful because (a) it adjusts argc
and (b) gives the expected result if options are specified.

Joerg

> 
> Regards,
> Douwe
> 
> 





More information about the Submit mailing list