pccard woes (probably rcNG buglet)

[Emiel Kollof]

Matthew Dillon wrote:

>     I have put a new patch up for dhclient at:
> 
>     http://apollo.backplane.com/FreeBSD/dfly-dhclient-01.diff
> 
>     It is basically a direct import from FreeBSD-current with the
>     802.11 specific ioctl's commented out.  I think it will still work
>     as expected but someone with a laptop (Emiel or David?) needs to test
>     it.
> 
>     It should properly work with interface.pid format pid files.

As far as I can tell, it works. Haven't tried without my hacked pccard_ether
script yet. The big problem seems to be this piece of shellscript in there:

------------
        [ -n "$dhcp_program" ] && dhclient_program="$dhcp_program"
        [ -n "$dhcp_flags" ] && dhclient_flags="$dhcp_flags"
        if [ -x "${dhclient_program}" ]; then
                if [ `basename ${dhclient_program}` = "dhclient" ]; then
                        pidfile="/var/run/dhclient.${interface}.pid"
                        dhclient_flags="${dhcp_flags} -pf ${pidfile}"
                fi
                ${dhclient_program} ${dhcp_flags} ${interface}
        else
                echo "${dhclient_program}: DHCP client software not
available"
        fi
------------

${dhcp_flags} seems to be ignored for some reason. Inserting a logger(1)
command with some choice vars after or before the line that executes
${dhcp_command} shows that. This dhclient still creates the standard 
/var/run/dhclient.pid instead of dhclient.${interface}.pid

There is one suspicion though. It might not even set ${pidfile} in said code
since in /etc/defaults/make.conf dhcp_flags is set to "". Does that effect
the -n flag in [(1)?
 
Cheers,
Emiel