(set|rem)runqueue and splhigh

Peter Kadau peter.kadau at tuebingen.mpg.de
Wed Dec 31 11:41:04 PST 2003


Hi !

    The comment is not correct.  setrunqueue() already enters a critical
    section (see the crit_enter() and crit_exit() in setrunqueue()), which
    is equivalent to splhigh().  So the following is not needed.
Ahh, sorry for bothering you. Since the attachment was *very* small
I didn't ask first, which I would have done otherwise.
So, how about the brackets in vm/vm_glue.c and kern/kern_fork.c
in swapout/faultin and start_forked_proc respectively ?
Are they still needed to protect the flags or are they artefacts as well ?
Cheers
Peter
--
<peter.kadau at xxxxxxxxxxxxxxxx>
Campus der Max-Planck-Institute Tübingen
Netzwerk- und Systemadministration
Tel: +49 7071 601 598
Fax: +49 7071 601 616





More information about the Submit mailing list