buildkernel failed - if_iwn.c: iwn_read_firmware (INVARIANTS again?)

[Sascha Wildner]

On Fri, 08 Nov 2013 13:26:45 +0100, Andrey Oktyabrskiy <ano at bestmx.net>  
wrote:

> $ make buildkernel KERNCONF=ANO
> ...
> /usr/src/sys/dev/netif/iwn/if_iwn.c: In function 'iwn_read_firmware':
> /usr/src/sys/dev/netif/iwn/if_iwn.c:5676:2: error: implicit declaration  
> of function 'IS_SERIALIZED' [-Werror=implicit-function-declaration]
> /usr/src/sys/dev/netif/iwn/if_iwn.c:5676:2: error: nested extern  
> declaration of 'IS_SERIALIZED' [-Werror=nested-externs]
> cc1: all warnings being treated as errors
> *** Error code 1

Yeah, it's a known issue and comes from compiling without INVARIANTS. IIRC  
I looked at it once and it didn't look so easy. It is also mentioned in  
http://bugs.dragonflybsd.org/issues/2449 (unfortunately closed  
prematurely).

CC'ing Matt since he both added the iwn code in question  
(b8b498ed88a72ccd6a0b0fd0d10a2061576f3a47) and added iwn to the default  
configs too (ae80e77cae0ebec810b46ecf9bf92428e28b8f7c). :)

We could #define INVARIANTS for the iwn driver only, but it would be kind  
of a hack. Any better ideas?

Sascha