Who broke NFS?

[Emiel Kollof]

Op maandag 4 december 2006 23:02, schreef Emiel Kollof:
> Hi, attached stack trace of a kernel panic from 1.7.0-preview. Reliably
> reproducable when starting KDE from another box when $HOME is a NFS mount
> from a DFly server.
>
> So, fess up, who broke NFS? :)
>
> Cheers,
> Emiel

A fix for this problem was found, thanks to TGEN and corecode. The case was 
that nch was NULL and dereferenced by that if over there. nch gets dropped 
before, so thatÅ› how that NULL deref was possible. Here's a patch that solves 
the problem for me:

--- nfs_subs.c  2006-10-27 06:56:34.000000000 +0200
+++ nfs_subs.c.fixed    2006-12-05 14:31:51.000000000 +0100
@@ -1604,8 +1604,8 @@
         */
        if (error == 0) {
                if (dvpp) {
+                       nch = nd->nl_nch;
                        if (nch.ncp->nc_parent) {
-                               nch = nd->nl_nch;
                                nch.ncp = nch.ncp->nc_parent;
                                error = cache_vget(&nch, nd->nl_cred,
                                                   LK_EXCLUSIVE, dvpp);


Cheers,
Emiel
-- 
If we do not change our direction we are likely to end up where we are headed.
Attachment:
pgp00004.pgp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pgp00004.pgp
Type: application/octet-stream
Size: 191 bytes
Desc: "Description: PGP signature"
URL: <http://lists.dragonflybsd.org/pipermail/kernel/attachments/20061205/5d365945/attachment-0020.obj>