git: devfs(5): Remove redundant checks to fix -Waddress warnings

Aaron LI aly at crater.dragonflybsd.org
Tue Oct 13 23:15:10 PDT 2026


commit 8a0abbc5649c964b3d537f547e3cd141695dd5b0
Author: Aaron LI <aly at aaronly.me>
Date:   Wed Oct 14 13:29:38 2026 +0800

    devfs(5): Remove redundant checks to fix -Waddress warnings
    
    The 'mntpoint', 'name' and 'linkname' fields are char arrays in
    'struct devfs_rule_ioctl', so the warned checks were redundant. Remove
    them to fix the '-Waddress' warnings given by GCC 12.5:
    
    ```
    /usr/src/sys/vfs/devfs/devfs_rules.c: In function 'devfs_rule_alloc':
    /usr/src/sys/vfs/devfs/devfs_rules.c:87:29: warning: the comparison will always evaluate as 'false' for the address of 'mntpoint' will never be NULL [-Waddress]
       87 |         if (templ->mntpoint == NULL)
          |                             ^~
    In file included from /usr/src/sys/vfs/devfs/devfs_rules.c:44:
    /usr/src/sys/sys/devfs_rules.h:74:17: note: 'mntpoint' declared here
       74 |         char    mntpoint[PATH_MAX];
          |                 ^~~~~~~~
    /usr/src/sys/vfs/devfs/devfs_rules.c:100:33: warning: the comparison will always evaluate as 'false' for the address of 'name' will never be NULL [-Waddress]
      100 |                 if (templ->name == NULL)
          |                                 ^~
    /usr/src/sys/sys/devfs_rules.h:76:17: note: 'name' declared here
       76 |         char    name[PATH_MAX];
          |                 ^~~~
    /usr/src/sys/vfs/devfs/devfs_rules.c:114:37: warning: the comparison will always evaluate as 'false' for the address of 'linkname' will never be NULL [-Waddress]
      114 |                 if (templ->linkname == NULL)
          |                                     ^~
    /usr/src/sys/sys/devfs_rules.h:78:17: note: 'linkname' declared here
       78 |         char    linkname[PATH_MAX];
          |                 ^~~~~~~~
    /usr/src/sys/vfs/devfs/devfs_rules.c: In function 'devfs_rule_clear':
    /usr/src/sys/vfs/devfs/devfs_rules.c:191:29: warning: the comparison will always evaluate as 'false' for the address of 'mntpoint' will never be NULL [-Waddress]
      191 |         if (templ->mntpoint == NULL)
          |                             ^~
    /usr/src/sys/sys/devfs_rules.h:74:17: note: 'mntpoint' declared here
       74 |         char    mntpoint[PATH_MAX];
          |                 ^~~~~~~~
    /usr/src/sys/vfs/devfs/devfs_rules.c: In function 'devfs_dev_ioctl':
    /usr/src/sys/vfs/devfs/devfs_rules.c:433:36: warning: the comparison will always evaluate as 'false' for the address of 'mntpoint' will never be NULL [-Waddress]
      433 |                 if (rule->mntpoint == NULL)
          |                                    ^~
    /usr/src/sys/sys/devfs_rules.h:74:17: note: 'mntpoint' declared here
       74 |         char    mntpoint[PATH_MAX];
          |                 ^~~~~~~~
    /usr/src/sys/vfs/devfs/devfs_rules.c:444:36: warning: the comparison will always evaluate as 'false' for the address of 'mntpoint' will never be NULL [-Waddress]
      444 |                 if (rule->mntpoint == NULL)
          |                                    ^~
    /usr/src/sys/sys/devfs_rules.h:74:17: note: 'mntpoint' declared here
       74 |         char    mntpoint[PATH_MAX];
          |                 ^~~~~~~~
    ```

Summary of changes:
 sys/vfs/devfs/devfs_rules.c | 25 ++-----------------------
 1 file changed, 2 insertions(+), 23 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/8a0abbc5649c964b3d537f547e3cd141695dd5b0


-- 
DragonFly BSD source repository


More information about the Commits mailing list