git: nata: Tweak 'struct dvd_miscauth' to fix -Warray-bounds warnings

Aaron LI aly at crater.dragonflybsd.org
Tue Oct 13 23:15:09 PDT 2026


commit 07dc6fd401407bb10ef219b4340c7c8aefa0efec
Author: Aaron LI <aly at aaronly.me>
Date:   Wed Oct 14 12:42:49 2026 +0800

    nata: Tweak 'struct dvd_miscauth' to fix -Warray-bounds warnings
    
    GCC 12.5 gave the warnings because the actual allocated space was
    smaller than sizeof(struct dvd_miscauth), which had the data[2048]
    field.  There is no code depend on sizeof(struct dvd_miscauth), so turn
    it into a flexible array to fix the -Warray-bounds warnings.
    
    GCC 12.5 warnings example:
    ```
    In function 'acd_send_key',
        inlined from 'acd_ioctl' at /usr/src/sys/dev/disk/nata/atapi-cd.c:756:14:
    /usr/src/sys/dev/disk/nata/atapi-cd.c:1476:20: warning: array subscript 'struct dvd_miscauth[0]' is partly outside array bounds of 'unsigned char[8]' [-Warray-bounds]
     1476 |         d->data[0] = ai->region;
          |         ~~~~~~~~~~~^~~~~~~~~~~~
    In file included from /usr/src/sys/dev/disk/nata/atapi-cd.c:42:
    In function '__kmalloc',
        inlined from 'acd_send_key' at /usr/src/sys/dev/disk/nata/atapi-cd.c:1475:6,
        inlined from 'acd_ioctl' at /usr/src/sys/dev/disk/nata/atapi-cd.c:756:14:
    /usr/src/sys/sys/malloc.h:280:32: note: object of size 8 allocated by '_kmalloc'
      280 |                 _malloc_item = _kmalloc(_size, _type, _flags & ~M_ZERO);
          |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In file included from /usr/src/sys/sys/types.h:42,
                     from /usr/src/sys/sys/param.h:279,
                     from /usr/src/sys/dev/disk/nata/atapi-cd.c:31:
    ```

Summary of changes:
 sys/dev/disk/nata/atapi-cd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/07dc6fd401407bb10ef219b4340c7c8aefa0efec


-- 
DragonFly BSD source repository


More information about the Commits mailing list