git: arcmsr.h: Include sys/bus.h header

Michael Neumann mneumann at crater.dragonflybsd.org
Sat Sep 27 02:37:20 PDT 2025


commit 794ce712837a78a41bc18e81958b1320bee28164
Author: Michael Neumann <mneumann at ntecs.de>
Date:   Fri Aug 8 16:10:23 2025 +0200

    arcmsr.h: Include sys/bus.h header
    
    The "arcmsr.h" header file uses types like bus_space_handle_t defined in
    "sys/bus.h", but it does not include the "sys/bus.h" header itself. This
    can cause build breakage elsewhere.
    
    The build of "usr.bin/kdump" depends on the auto-generated file
    "ioctl.c" created by the "mkioctls" script. Within the generated
    "ioctl.c" file, various header files are included. Some of these header
    files (namely "arcmsr.h") might depend on the order in which the header
    files are included or depend on other header files being included before
    themselves.
    
    In the process of removing cryptodev, I noticed build breakage of kdump
    when "sys/cryptodev.h" is removed. This is because "sys/cryptodev.h"
    includes "sys/bus.h" and is placed before the include of "arcmsr.h"
    (within the auto-generated "ioctl.c"). So removing "sys/cryptodev.h"
    would lead to type definitions from "arcmsr.h" refering to yet undefined
    types from "sys/bus.h".

Summary of changes:
 sys/dev/raid/arcmsr/arcmsr.h | 1 +
 1 file changed, 1 insertion(+)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/794ce712837a78a41bc18e81958b1320bee28164


-- 
DragonFly BSD source repository


More information about the Commits mailing list