From mneumann at crater.dragonflybsd.org Sun Jun 1 15:28:00 2025 From: mneumann at crater.dragonflybsd.org (Michael Neumann) Date: Sun, 1 Jun 2025 15:28:00 -0700 (PDT) Subject: git: atkbd: fix style Message-ID: <20250601222800.294C92B477BF@crater.dragonflybsd.org> commit 91c130d4cd33e3e5a424317d71c311b8551594e7 Author: Michael Neumann Date: Sun Jun 1 23:15:32 2025 +0200 atkbd: fix style Use struct initializer syntax. No functional change. Summary of changes: sys/dev/misc/kbd/atkbdc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/91c130d4cd33e3e5a424317d71c311b8551594e7 -- DragonFly BSD source repository From mneumann at crater.dragonflybsd.org Sun Jun 1 15:28:00 2025 From: mneumann at crater.dragonflybsd.org (Michael Neumann) Date: Sun, 1 Jun 2025 15:28:00 -0700 (PDT) Subject: git: atkbd: remove unused code that measures inb() duration Message-ID: <20250601222800.47BBA2B477C1@crater.dragonflybsd.org> commit e8a55a738e13fefc537781ebe64754e09b754751 Author: Michael Neumann Date: Sun Jun 1 23:20:25 2025 +0200 atkbd: remove unused code that measures inb() duration We are not using the retry count as FreeBSD does. Instead, we are using TOTALDELAY / CHECKTIMEOUT, which measures the actual execution time after each loop iteration and breaks out of the loop when the total time (70ms or 200ms in most cases) has expired. Summary of changes: sys/dev/misc/kbd/atkbdc.c | 25 ------------------------- sys/dev/misc/kbd/atkbdcreg.h | 1 - 2 files changed, 26 deletions(-) http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/e8a55a738e13fefc537781ebe64754e09b754751 -- DragonFly BSD source repository From mneumann at crater.dragonflybsd.org Sun Jun 1 15:28:00 2025 From: mneumann at crater.dragonflybsd.org (Michael Neumann) Date: Sun, 1 Jun 2025 15:28:00 -0700 (PDT) Subject: git: atkbd: print out message if AT keyboard controller not found Message-ID: <20250601222800.648E72B477C4@crater.dragonflybsd.org> commit 930ae2551906942ac125a661933211e38351955a Author: Michael Neumann Date: Sun Jun 1 23:29:08 2025 +0200 atkbd: print out message if AT keyboard controller not found Taken-from: FreeBSD Summary of changes: sys/dev/misc/atkbdc_layer/atkbdc_isa.c | 2 ++ 1 file changed, 2 insertions(+) http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/930ae2551906942ac125a661933211e38351955a -- DragonFly BSD source repository From mneumann at crater.dragonflybsd.org Sun Jun 1 15:28:00 2025 From: mneumann at crater.dragonflybsd.org (Michael Neumann) Date: Sun, 1 Jun 2025 15:28:00 -0700 (PDT) Subject: git: atkbd: Fix first keystroke force reset Message-ID: <20250601222800.8942E2B477C7@crater.dragonflybsd.org> commit f0dd2afff203c65de3b0eed1b65d7875a0201212 Author: Michael Neumann Date: Sun Jun 1 23:41:14 2025 +0200 atkbd: Fix first keystroke force reset Some i8042 falsely return KBD_ACK for ECHO command which cause the keyboard echo test to fail. Without passing echo test, the keyboard is considered as unconfigured. Although this is incorrect behavior, we still consider it correct to prevent the forced reset (a step to configure a keyboard) of the entire keyboard when the first key interrupt is reached. This should fix keyboard probing at least for Framework Laptop [1]. Taken-from: FreeBSD [2] (minus typos) [1]: https://reviews.freebsd.org/D50498 [2]: https://github.com/freebsd/freebsd-src/commit/cba5d7ab32fd0b4e9c4312cc967baf137377f812 Summary of changes: sys/dev/misc/kbd/atkbd.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/f0dd2afff203c65de3b0eed1b65d7875a0201212 -- DragonFly BSD source repository