git: sys/vfs/hammer2: Fix many comments
Tomohiro Kusumi
tkusumi at crater.dragonflybsd.org
Sat Nov 5 14:36:28 PDT 2022
commit ee92f60939d1e262cef9eac8ff4be09606b1daa7
Author: Tomohiro Kusumi <tkusumi at netbsd.org>
Date: Fri Nov 4 22:30:18 2022 -0700
sys/vfs/hammer2: Fix many comments
* "lru_spin; /* inumber lookup */" -> lru_spin isn't for inode.
* "If an error occurred we eat the lock" -> "eat the lock" was
removed in c603b86b77206805493fc181d3576ecd1786e056 in 2015.
The rest of the comment (not removed) seems obsolete too.
* "removed from the parent's btree" -> Typo for rbtree.
* "pointing it to an embedded data structure and copying the data from the buffer"
-> No longer implemented like this since
01eabad4d93a8dc8f0f01a6209b384b1e010bb8c in 2012.
* "Called to clean up cached DIOs on umount" -> This isn't specific to
unmount, called regularly if iofree_count > dio_limit.
* "voldata is not yet loaded" -> It's already loaded.
* "so do not pass cluster", etc -> "cluster" no longer appears
here since b7add6753e221920947c96fab3314c39a2f67fe4 in 2015.
* "multiple hammer2_inode structures can be aliased to the same chain
element, for example for hardlinks" -> This comment from 2013
seems to only apply to hardlink mechanism back then, which was
something completely different.
Summary of changes:
sys/vfs/hammer2/hammer2.h | 2 +-
sys/vfs/hammer2/hammer2_admin.c | 2 +-
sys/vfs/hammer2/hammer2_chain.c | 14 ++------------
sys/vfs/hammer2/hammer2_io.c | 3 ---
sys/vfs/hammer2/hammer2_vfsops.c | 9 ++-------
sys/vfs/hammer2/hammer2_vnops.c | 5 -----
6 files changed, 6 insertions(+), 29 deletions(-)
http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/ee92f60939d1e262cef9eac8ff4be09606b1daa7
--
DragonFly BSD source repository
More information about the Commits
mailing list