git: kernel/iscsi: Remove iscsi's local definition of boolean_t.
Sascha Wildner
swildner at crater.dragonflybsd.org
Tue Aug 11 14:33:00 PDT 2020
commit ae2af236d6dbf1e0517703bc85434116d22d0eee
Author: Sascha Wildner <saw at online.de>
Date: Tue Aug 11 23:30:51 2020 +0200
kernel/iscsi: Remove iscsi's local definition of boolean_t.
It was locally defining boolean_t as int (4 bytes) for userland, but
boolean_t is _Bool (1 byte) in the kernel since quite some time.
This caused isc_opt_t's size being different in userland vs. kernel,
and ultimately caused the ioctl number of ISCSISETOPT, which includes
sizeof(isc_opt_t), to be different in userland vs. the kernel,
resulting in at first inexplicable ENOIOCTL issues when using
iscontrol(8).
Change all 'boolean_t' usage to 'bool' which is available for both
userland and kernel, defined as _Bool.
Thanks-to: Georg "megaT" Bege <georg at bege.email> for spotting the ioctl
number difference & testing
Summary of changes:
sbin/iscontrol/iscontrol.c | 8 ++++----
sys/dev/disk/iscsi/initiator/isc_cam.c | 2 +-
sys/dev/disk/iscsi/initiator/iscsi.h | 14 +++++++-------
3 files changed, 12 insertions(+), 12 deletions(-)
http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/ae2af236d6dbf1e0517703bc85434116d22d0eee
--
DragonFly BSD source repository
More information about the Commits
mailing list