git: if_tun: Use pointer to ifnet in tun_softc struct

Sepherosa Ziehau sepherosa at gmail.com
Thu Jul 19 19:43:16 PDT 2018


On Fri, Jul 20, 2018 at 10:19 AM, Aaron LI <aly at aaronly.me> wrote:
> On Fri, 20 Jul 2018 09:40:21 +0800
> Sepherosa Ziehau <sepherosa at gmail.com> wrote:
>
>> Most of the physical drivers are ethernet ones, so they need arpcom;
>> please do w/ care.
>
> Sure, I have to understand the drivers more before really touching them.
>
>> I am not quite sure why we want to use if_alloc() in the first place?
>
> Since our if_alloc() is very simple, so there is no big benefit to use it
> over the direct kmalloc().  But if_alloc() is easier to use and more
> intuitive.

I mean why allocate in the first place?  What's wrong w/ embedding?

>
>> We don't have the synchronization issue if_alloc() tries to address
>> in FreeBSD.
>
> Cool!
>
>
> Cheers,
> --
> Aaron



-- 
Tomorrow Will Never Die



More information about the Commits mailing list