git: sbin/mount_hammer: Remove redundant test_volumes() on mount(2) failure
Tomohiro Kusumi
tkusumi at crater.dragonflybsd.org
Sat Sep 30 11:37:02 PDT 2017
commit 1767454fc3cdb440b6ee35b74ec70f13687cd169
Author: Tomohiro Kusumi <kusumi.tomohiro at gmail.com>
Date: Sat Sep 30 14:21:25 2017 +0300
sbin/mount_hammer: Remove redundant test_volumes() on mount(2) failure
This code was originally added by 1a607e3e which added signature check
when mount(2) failed, and later modified by several commits including
1e297b34 which copied code from sbin/hammer/ondisk.c. But as mentioned
in 1e297b34, this entire checking wasn't needed (as it's in dmesg),
or it may even show the wrong reason of failure.
The correct way is to just type dmesg, and see what the kernel said,
instead of resorting to wild guess in userspace by reading volume header
*after* mount(2) failure (If you really want this it should be done
*before* mount(2)).
This originally didn't exist till 2009 and that was better.
Summary of changes:
sbin/mount_hammer/mount_hammer.c | 68 ----------------------------------------
1 file changed, 68 deletions(-)
http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/1767454fc3cdb440b6ee35b74ec70f13687cd169
--
DragonFly BSD source repository
More information about the Commits
mailing list