git: sbin/hammer: Mention bug in hammer recover command

Tomohiro Kusumi tkusumi at crater.dragonflybsd.org
Sat Oct 15 09:27:32 PDT 2016


commit f2dd4b0c012464d21bf5733282e4091c2b580f8a
Author: Tomohiro Kusumi <kusumi.tomohiro at gmail.com>
Date:   Sat Oct 15 23:46:57 2016 +0900

    sbin/hammer: Mention bug in hammer recover command
    
    newfs_hammer overwrites layer1/2, but doesn't overwrite data in
    blockmap beyond layer1/2, so old data is still there if the volume
    has been re-formatted until the new fs overwrites old fs by using
    more disk space than the old fs.
    
    This is usually not a problem because the new fs doesn't have a
    pointer to data in old fs, but hammer recover just iterates zone-2
    offset till it hits end of the disk space which may include data
    from the old fs. As mentioned in the comment, it's likely to hit
    assertion if the old data located near the end of the volume is
    B-Tree nodes depending on situation of the old fs.

Summary of changes:
 sbin/hammer/cmd_recover.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/f2dd4b0c012464d21bf5733282e4091c2b580f8a


-- 
DragonFly BSD source repository



More information about the Commits mailing list