git: sbin/hammer: Remove AssertOnFailure assertion in blockmap lookup

Tomohiro Kusumi tkusumi at crater.dragonflybsd.org
Sun Aug 21 00:44:44 PDT 2016


commit 72e23ddf80e56ca3257f04d6caf7021ae64f9416
Author: Tomohiro Kusumi <kusumi.tomohiro at gmail.com>
Date:   Sun Aug 21 15:07:30 2016 +0900

    sbin/hammer: Remove AssertOnFailure assertion in blockmap lookup
    
    This isn't necessary as blockmap_lookup() callers are going to
    check returned offset and/or *errorp value. Callers don't want
    blockmap_lookup() to kill the process instantly via errx()
    especially when the callers are diagnostic commands like hammer
    show or blockmap or checkmap.
    
    This is also the only place where AssertOnFailure needs to be
    a global variable. Once this gets removed, other ones can be
    removed or changed to local variables.

Summary of changes:
 sbin/hammer/blockmap.c | 5 -----
 sbin/hammer/ondisk.c   | 8 ++++----
 2 files changed, 4 insertions(+), 9 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/72e23ddf80e56ca3257f04d6caf7021ae64f9416


-- 
DragonFly BSD source repository



More information about the Commits mailing list