git: sbin/hammer: Don't print mountpoint of PFS

Tomohiro Kusumi tkusumi at
Tue Aug 23 05:34:46 PDT 2016

commit d6c59c720c8103f8d9c75cf66dcfbd14d3ecdc90
Author: Tomohiro Kusumi <kusumi.tomohiro at>
Date:   Tue Aug 23 19:59:26 2016 +0900

    sbin/hammer: Don't print mountpoint of PFS
    /sbin/hammer should not care if PFS are null mounted or where PFS are
    mounted. It has nothing to do with the filesystem itself. PFS is just
    a pointer to jump into a subset of HAMMER's B-Tree (clustered by
    localization parameter). Just because DragonFly's installer used to
    use PFS (not anymore) and null mount by default doesn't mean /sbin
    /hammer needs to provide null mount info.
    If someone does mount PFS to somewhere and want to know where PFS are
    mounted, one needs to just type mount. In fact this is much better
    than getting mountpoints info via hammer info command because mount(8)
    doesn't use hammer's ioctl which may cause B-Tree lookup, but instead
    retrieves mountpoints directly from vfs.
    Also note that printing such info gives users wrong assumption that
    PFS in HAMMER is something equivalent of ZFS (created out of storage
    zpool) which is not true. As mentioned above, PFS is just a pointer to
    a subset of a single HAMMER filesystem. These are not independent fs.
    Also note that hammer info still has bugs due to bugs from libhammer
    and its attached ioctl as mentioned in e0f42079, including things under
    investigation now. Whatever it is, hammer info needs to be rewritten
    (as a different command like hammer fsinfo) in short and straight
    forward code like other commands, without unnecessary abstraction.
    I've been fixing and adding missing stuff to this hammer info command,
    however hammer info is basically going nowhere because this command is
    too tightly attached to libhammer.

Summary of changes:
 sbin/hammer/cmd_info.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

DragonFly BSD source repository

More information about the Commits mailing list