git: sys/vfs/hammer: Add error messages for crc test failure
tkusumi at crater.dragonflybsd.org
Sat Oct 10 05:46:00 PDT 2015
Author: Tomohiro Kusumi <kusumi.tomohiro at gmail.com>
Date: Sat Sep 26 02:04:37 2015 +0900
sys/vfs/hammer: Add error messages for crc test failure
Add crc error messages based on the existing error message
in hammer_btree_extract(). The one in hammer_mirror.c is
a part of #if0'd function.
23:27 (tkusumi) too many error = EIO; but possibly bad crc ?
23:28 (tkusumi) if bad crc is the case turning on hammer_debug_critical leads to Debugger("CRC FAILED: B-TREE NODE");
23:40 (dillon) it's likely a CRC failure, though I think it should print those out on the console too
23:54 (tkusumi) some bad crc are missing "CRC DATA @ %016llx/%d FAILED\n"
23:59 (dillon) those could be added for clarity. Almost universally EIO from hammer means a bad CRC and not an actual disk read error.
23:59 (dillon) USB-connected hard drives seem to get these. I've never gotten a bad CRC from a SATA-connected HDD via the AHCI driver.
Summary of changes:
sys/vfs/hammer/hammer_mirror.c | 4 +++-
sys/vfs/hammer/hammer_object.c | 4 +++-
sys/vfs/hammer/hammer_ondisk.c | 3 +++
3 files changed, 9 insertions(+), 2 deletions(-)
DragonFly BSD source repository
More information about the Commits