git: sys/dev/disk/dm: Remove upcall handler

Tomohiro Kusumi tkusumi at crater.dragonflybsd.org
Sat Nov 7 07:37:27 PST 2015


commit 333a8a0c699ac8ed9876ac61b44aba1d15054bc6
Author: Tomohiro Kusumi <kusumi.tomohiro at gmail.com>
Date:   Sat Nov 7 23:05:09 2015 +0900

    sys/dev/disk/dm: Remove upcall handler
    
    dm target's upcall() handler
      int (*upcall)(dm_table_entry_t *, struct buf *);
    implemented by dm targets acutally do nothing other than
    returning 0. Also note that upcall() is not used by dm core.
    
    The targets that are supposed to be relying on this api are
    obviously not working at the moment, however things aren't
    as simple as just implementing missing upcall() handler.
    
    upcall() is supposed to be something to do with targets like
    snapshot, but it lacks documentation and purpose of this api
    is not clear at all. Whoever tries to implement snapshot/etc
    will have to re-design dm core and appropriate handlers from
    scratch anyway without using the existing one.

Summary of changes:
 sys/dev/disk/dm/dm.h                                |  6 ------
 sys/dev/disk/dm/dm_ioctl.c                          |  3 +--
 sys/dev/disk/dm/dm_target_error.c                   |  8 --------
 sys/dev/disk/dm/dm_target_zero.c                    |  8 --------
 sys/dev/disk/dm/targets/crypt/dm_target_crypt.c     |  8 --------
 sys/dev/disk/dm/targets/delay/dm_target_delay.c     |  7 -------
 sys/dev/disk/dm/targets/linear/dm_target_linear.c   | 12 ------------
 sys/dev/disk/dm/targets/mirror/dm_target_mirror.c   |  7 -------
 .../disk/dm/targets/snapshot/dm_target_snapshot.c   | 21 ---------------------
 sys/dev/disk/dm/targets/striped/dm_target_striped.c | 10 ----------
 10 files changed, 1 insertion(+), 89 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/333a8a0c699ac8ed9876ac61b44aba1d15054bc6


-- 
DragonFly BSD source repository


More information about the Commits mailing list