git: sys/sys: Remove VFS_MPLOCK2 macro
Tomohiro Kusumi
tkusumi at crater.dragonflybsd.org
Sun May 10 05:52:59 PDT 2015
commit e47b73c65d312cf196178b1110166a8d203abaeb
Author: Tomohiro Kusumi <kusumi.tomohiro at gmail.com>
Date: Sun May 10 06:28:25 2015 +0900
sys/sys: Remove VFS_MPLOCK2 macro
- Not only vfs and filesystems are NOT using this macro,
but also this macro doesn't work given that
- The local variable 'xlock_mpsafe' (which is visibly hidden
from vfs C code) is being used without initializing, while
this header doesn't provide a macro to initialze it.
(even if it did provide the purpose of VFS_MPLOCK2 isn't
very clear either).
- VFS_MPLOCK1 is the only one that works as expected and all
the syscalls actually use this. Replacing VFS_MPLOCK1 with
VFS_MPLOCK2 results compile error with -Werror=uninitialized.
error: 'xlock_mpsafe' is used uninitialized in this function
[-Werror=uninitialized]
if (xlock_mpsafe) {
Summary of changes:
sys/kern/vfs_vopops.c | 3 +--
sys/sys/mount.h | 9 ---------
2 files changed, 1 insertion(+), 11 deletions(-)
http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/e47b73c65d312cf196178b1110166a8d203abaeb
--
DragonFly BSD source repository
More information about the Commits
mailing list