git: install(1): Fix 2.5 y/o verbose bug, use static functions

Sascha Wildner saw at online.de
Thu Feb 6 06:14:10 PST 2014


On Thu, 06 Feb 2014 14:37:26 +0100, John Marino  
<marino at crater.dragonflybsd.org> wrote:

>     Finally, several functions were turned into static functions and  
> explicit
>     void casts were used when functions normally return integers.

I don't really see the point in bringing in the (void) casts. We  
explicitly removed them back in 2004/2005 for large parts of base when it  
was agreed that they are just eyesores mostly, and - since we do not put  
them in new code we write, either - the best we can achieve is an  
inconsistent mix.

Stylistic changes such as those only make sense (IMO) when we can hope for  
consistency and/or check for it or enforce it somehow.

Sascha



More information about the Commits mailing list