git: install(1): Fix 2.5 y/o verbose bug, use static functions
John Marino
marino at crater.dragonflybsd.org
Thu Feb 6 05:37:26 PST 2014
commit a88cc817133093499245c4dd191df21b50624995
Author: John Marino <draco at marino.st>
Date: Thu Feb 6 14:33:01 2014 +0100
install(1): Fix 2.5 y/o verbose bug, use static functions
A bug was introduced by this commit to add the -D option:
a2bc4e56d4ab068fea12d65d13740b7a600769a8 (7 SEP 11)
It changed the -v verbose option from standalone to expecting input and
as a result, any use of -v caused the usage screen to come up. Fixed.
Additionally, the pathnames.h header is unused, removed now.
Finally, several functions were turned into static functions and explicit
void casts were used when functions normally return integers. The last
two change sets converge with FreeBSD.
xinstall has not been seriously updated in a long time and has fallen
behind BSD counterparts. Syncing with FreeBSD may take several steps as
there is significant divergence and options (e.g. -l) do different things
on FreeBSD
Summary of changes:
usr.bin/xinstall/pathnames.h | 36 ------------
usr.bin/xinstall/xinstall.c | 127 +++++++++++++++++++++++--------------------
2 files changed, 67 insertions(+), 96 deletions(-)
delete mode 100644 usr.bin/xinstall/pathnames.h
http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/a88cc817133093499245c4dd191df21b50624995
--
DragonFly BSD source repository
More information about the Commits
mailing list