git: kernel/cam: Fix I/O performance regression seen at least in VMware ESXi.

Sascha Wildner swildner at crater.dragonflybsd.org
Sun Aug 25 11:18:49 PDT 2013


commit c0c84ec8c33cbfcb5cd11375d09e05a73d64f0c2
Author: Sascha Wildner <saw at online.de>
Date:   Sun Aug 25 20:15:37 2013 +0200

    kernel/cam: Fix I/O performance regression seen at least in VMware ESXi.
    
    This brings in FreeBSD's revisions 188570, 188670, 188671 and 188688.
    188670 (most changed lines in the patch) is for debugging purposes only,
    while 188570 and 188671 fix the actual issue and 188688 fixes gcc whining.
    
    Reported-and-tested-by: Dongsheng Song <dongsheng.song at gmail.com>
    
    Extra credit to vsrinivas who had actually pointed out 188570 to us a
    while ago before it hit us now but at the time I hadn't noticed.
    
    Quoting FreeBSD's commit messages:
    
    r188570
    -------
    In the case that the probe has determined that it can't query the device
    for a serial number, fall through to the next case so that initial
    negotiation still happens.  Without this, devices were showing up with
    only 1 available tag opening, leading to observations of very poor I/O
    performance.
    
    This should fix problems reported with VMWare Fusion and ESX.  Early
    generation MPT-SAS controllers with SATA disks might also be affected.
    HP CISS controllers are also likely affected, as are many other
    pseudo-scsi disk subsystems.
    
    r188671
    -------
    Fix parallel SCSI negotiation in the CAM_NEW_TRAN_CODE world order.
    Overzealous sanity checks were locking the sync_rate and offset values
    to zero, thanks to a twisty maze of recursive code.

Summary of changes:
 sys/bus/cam/cam_xpt.c | 85 ++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 61 insertions(+), 24 deletions(-)

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/c0c84ec8c33cbfcb5cd11375d09e05a73d64f0c2


-- 
DragonFly BSD source repository


More information about the Commits mailing list