git: acpi_thinkpad(4): make acpi_thinkpad sensors actually work
Constantine A. Murenin
cnst at crater.dragonflybsd.org
Thu Feb 18 02:32:04 PST 2010
On 18 February 2010 02:51, Constantine A. Murenin
<cnst at crater.dragonflybsd.org> wrote:
> commit 20b3fbb5f22fcbc17e90863f7363a7918c04cbd2
> Author: Constantine A. Murenin <cnst+dfly at bugmail.mojo.ru>
> Date: Thu Feb 18 02:13:00 2010 -0500
> acpi_thinkpad(4): make acpi_thinkpad sensors actually work
> * After this patch on my ThinkPad R51:
> %sysctl hw.sensors.acpi_ibm0
> hw.sensors.acpi_ibm0.temp0: 69.00 degC
> hw.sensors.acpi_ibm0.temp1: 52.00 degC
> hw.sensors.acpi_ibm0.temp2: 41.00 degC
> hw.sensors.acpi_ibm0.temp3: 59.00 degC
> hw.sensors.acpi_ibm0.temp4: 36.00 degC
> hw.sensors.acpi_ibm0.temp5: invalid
> hw.sensors.acpi_ibm0.temp6: 26.00 degC
> hw.sensors.acpi_ibm0.temp7: invalid
> hw.sensors.acpi_ibm0.fan0: 3469 RPM
> * Before this patch:
> o The temperature values were absolutely random, since
> the /data/ variable was never initialised from temp[i].
> o The braces were missing from the fan error path of
> an if statement.
> o Whitespaces were used instead of tabs.
> Summary of changes:
> sys/dev/acpica5/acpi_thinkpad/acpi_thinkpad.c | 45 +++++++++++-------------
> 1 files changed, 21 insertions(+), 24 deletions(-)
> DragonFly BSD source repository
Hum, and it would look that this fixes only a small part of the
breakages that were introduced to acpi_thinkpad with 10f97674 on
2009-11-08. Others include stuff like the unintended and partial
rename of acpi_thinkpad back to acpi_ibm, and change of many
freebsd.org email addresses to kfreebsd.org.
Someone with more interest and spare time should perhaps take a look
at a possible (partial?) backout.
More information about the Commits