DragonFly- master sys/bus/pci/amd64 pci_cfgreg.c sys/bus/pci/i386 pci_cfgreg.c

Sepherosa Ziehau sephe at crater.dragonflybsd.org
Fri Feb 6 02:51:34 PST 2009

commit 16c751ca33dd2f66ee5626e66dcf07f6cd02cfce
Author: Sepherosa Ziehau <sephe at dragonflybsd.org>
Date:   Wed Feb 4 18:39:27 2009 +0800

    pci intr config: Fix an off by one bug
    FreeBSD pci_pir.c rev1.105
      We represent PCI intpin's two different ways.  One is the way that the
      intpin register is expressed in hardware where 0 means none, 1 means INTA,
      2 INTB, etc.  The other way is commonly used in loops where 0 means INTA,
      1 means INTB, etc.  The matchpin argument to pci_cfgintr_search() is
      supposed to be the first form, but we passsed in a loop index of the
      second.  This fix adds one to the loop index to convert to the first form.
      Reported by:	Pavlin Radoslavov <pavlin at icir.org>

Summary of changes:
 sys/bus/pci/amd64/pci_cfgreg.c |    2 +-
 sys/bus/pci/i386/pci_cfgreg.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


DragonFly BSD source repository

More information about the Commits mailing list